Skip to content

gh-144156: Fix email header folding concatenating encoded words#144692

Open
robsdedude wants to merge 14 commits intopython:mainfrom
robsdedude:fix/gh-144156
Open

gh-144156: Fix email header folding concatenating encoded words#144692
robsdedude wants to merge 14 commits intopython:mainfrom
robsdedude:fix/gh-144156

Conversation

@robsdedude
Copy link
Contributor

@robsdedude robsdedude commented Feb 10, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 10, 2026
Open
@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@robsdedude robsdedude changed the title gh-144156: Fix email header wrapping omitting white space gh-144156: Fix email header folding concatenating encoded words Feb 10, 2026
@robsdedude robsdedude marked this pull request as ready for review February 11, 2026 13:32
@robsdedude robsdedude requested a review from a team as a code owner February 11, 2026 13:32
aisk
aisk reviewed Feb 11, 2026
View reviewed changes
aisk
aisk reviewed Feb 11, 2026
View reviewed changes
@bitdancer
Copy link
Member

bitdancer commented Feb 11, 2026

FYI I've been looking at this and will have a review soonish. You are correct that the gh-92281 fix was buggy.

bitdancer
bitdancer requested changes Feb 12, 2026
View reviewed changes
Copy link
Member

@bitdancer bitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

I edited this review a bunch, so mistake could have crept in to my code suggestions, though I did test them. The randomizer test should catch any transcription errors if nothing else does.

@bedevere-app
Copy link

bedevere-app bot commented Feb 12, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@robsdedude
Fix broken application of news fragment suggestion
a1cfe3c
@robsdedude
Simplify code
45022be 
Make use of the fact that folder must never produce a line of only WSP.
@robsdedude
Fix related WSP folding bug
ccf399d
bitdancer
bitdancer requested changes Feb 13, 2026
View reviewed changes
@bitdancer
Copy link
Member

bitdancer commented Feb 18, 2026

Just the elif change and this will be ready to go.

@robsdedude robsdedude requested a review from bitdancer February 19, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robsdedude @bitdancer @aisk

Comments